Added Windows support #57

bedware · 2023-06-26T18:52:45Z

Trying to solve that issue - #4

bedware · 2023-06-26T19:04:35Z

I have managed to run several commands like:

Info
Choose Port
Verify
Upload
Monitor Serial port
Others can also work, I didn't check

I'm using Windows 10.

Some requirements to use this patch:

~~pwsh installed (cross-platform version 7+)~~
arduino-cli installed

Unfortunately, I can't test on a clean system and am afraid of side effects that may happen. I would appreciate any help with testing.

I do this in Draft because I don't know Lua and I hope someone can help me review my Lua code. Especially why I just can't make my nested substitute multiline? :\

stevearc · 2023-06-27T15:25:51Z

autoload/arduino.vim

@@ -47,6 +47,11 @@ function! arduino#InitializeConfig() abort
  endif
  if !exists('g:arduino_serial_cmd')
    let g:arduino_serial_cmd = 'screen {port} {baud}'
+    if s:OS ==? 'Windows'
+      let g:arduino_serial_cmd = 'arduino-cli monitor -p {port} --config baudrate={baud}'


If the arduino-cli supports reading the serial output now, we should just use this as the new default (provided s:has_cli)

Yes, this is supported. In fact, I didn't know it wasn't supported before. I think it is a good idea to use it as default.

stevearc · 2023-06-27T15:42:56Z

autoload/arduino.vim

+  if s:OS ==? 'Windows'
+    let found = split(system('pwsh -nop -c "arduino-cli board list | Select-String -Pattern \"^(COM\d) \" | ForEach-Object { $_.Matches.Value }"'), '\n')
+    for port in found
+      call add(ports, port)
+    endfor
+  endif 


Would prefer if you could call arduino-cli directly so it doesn't rely on powershell. Do the ports appear in the json data if you run it like we do here?

vim-arduino/autoload/arduino.vim

Line 251 in 111db61

let boards_data = json_decode(system('arduino-cli board listall --format json'))

If not, you could still just call arduino-cli board list and the extract the information you want using matchlist().

This makes sense. I'm gonna change it.

stevearc · 2023-06-27T15:43:50Z

autoload/arduino.vim

+  let l:path = substitute(l:path, '{file}', substitute(expand('%:p'), '\', '/', 'g'), 'g')
+  let l:path = substitute(l:path, '{project_dir}', substitute(expand('%:p:h'), '\', '/', 'g'), 'g')


Is this what you mean when you say the nested substitutes are not working? What specifically isn't working about them?

I apologize for the confusion. Nested substitutions work fine. I will write another message about what is working as I not expecting.

I used this hack to make it work on Windows. I don't know why any path on Windows is composed using backslashes. Without changing slashes topmost substitute interpreted '\U' sequence as a trigger to make the next characters UPPERCASE. But on Windows path quite often starts with the C:/User/<username> prefix. That broke compiling and uploading.

bedware · 2023-06-28T16:39:28Z

What I meant is that subs(subs( work as expected, but when I tried to make nested subs on the new line - it stop working. I think It is due to my limited knowledge of Lua.

# works
  let l:path = substitute(l:path, '{file}', substitute(expand('%:p'), '\', '/', 'g'), 'g')

# doesn't work
  let l:path = substitute(l:path, '{file}', substitute(
    expand('%:p'), '\', '/', 'g'), 'g')

bedware · 2023-06-28T17:15:43Z

Also I noticed that <leader>aus doesn't work. But <leader>as works fine. Here is the output:

Writing | ################################################## | 100% 0.77s

avrdude: 2514 bytes of flash written

avrdude done.  Thank you.


^[[92mUsed platform^[[0m        ^[[92mVersion^[[0m ^[[90mPath^[[0m

^[[93matmel-avr-xminis:avr^[[0m 0.6.0   ^[[90mC:\Users\dmitr\AppData\Local\Arduino15\packages\atmel-avr-xminis\hardware\avr\0.6.0^[[0m
^[[93marduino:avr^[[0m          1.8.6   ^[[90mC:\Users\dmitr\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.6^[[0m

:!arduino-cli monitor -p COM4 --config baudrate=9600
not running in a terminal

shell returned 1

Do you have any ideas on how to solve this? Looks like aus somehow depends on terminal commands, but not using just regular as command. Am I right? I saw something in the code, but I need further investigation.

stevearc · 2023-06-29T02:29:38Z

What version of vim are you using? We're running the command like so

vim-arduino/autoload/arduino.vim

Line 98 in 111db61

exe s:TERM . a:cmd

and s:TERM is set via this logic

vim-arduino/autoload/arduino.vim

Lines 13 to 21 in 111db61

    
           if has('nvim') 
        
             let s:TERM = 'botright split | terminal! ' 
        
           elseif has('terminal') 
        
             " In vim, doing terminal! will automatically open in a new split 
        
             let s:TERM = 'terminal! ' 
        
           else 
        
             " Backwards compatible with old versions of vim 
        
             let s:TERM = '!' 
        
           endif

Both of the terminal options should run the command inside a terminal. From the logs you pasted, it looks like you might have just been doing a raw shell execution :!<cmd>

bedware · 2023-07-12T18:53:41Z

Upload & Serial works for me now and it is a much better experience.
Now all general things are working. How we can publish this? Do I need to make some tests or something else?
I really want to publish this =)

bedware · 2023-07-12T18:56:05Z

What version of vim are you using? We're running the command like so

NVIM v0.9.1

stevearc

Looking good! Couple of small refactors requested

stevearc · 2023-07-14T19:22:36Z

autoload/arduino.vim

+    if g:arduino_use_cli
+      let g:arduino_serial_cmd = 'arduino-cli monitor -p {port} --config baudrate={baud}'
+    endif


I would move this into the if !exists('g:arduino_serial_cmd') above (line 49). Move that check below this one, and then set it to be the default serial command if g:arduino_use_cli

stevearc · 2023-07-14T19:28:04Z

autoload/arduino.vim

+  if s:OS ==? 'Windows'
+    let boards_data = json_decode(system('arduino-cli board list --format json'))
+    for board in boards_data
+      call add(ports, board['port']['address'])
+    endfor
+  endif 


Does this have to be windows-only? It seems like this API should work on all platforms. We should put it behind a if g:arduino_use_cli check, though. And also deduplicate any entries in the list.

Draft: Added Windows support

fbf2917

stevearc reviewed Jun 27, 2023

View reviewed changes

Removed pwsh dep. arduino-cli monitor by default.

8739195

bedware marked this pull request as ready for review June 28, 2023 17:09

Fixed Upload & Serial

bc739e6

bedware marked this pull request as draft July 12, 2023 18:56

bedware changed the title ~~Draft: Added Windows support~~ Added Windows support Jul 12, 2023

bedware marked this pull request as ready for review July 12, 2023 19:00

stevearc requested changes Jul 14, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Windows support #57

Added Windows support #57

bedware commented Jun 26, 2023

bedware commented Jun 26, 2023 •

edited

Loading

stevearc Jun 27, 2023

bedware Jun 28, 2023

stevearc Jun 27, 2023

bedware Jun 28, 2023

stevearc Jun 27, 2023

bedware Jun 28, 2023

bedware commented Jun 28, 2023

bedware commented Jun 28, 2023

stevearc commented Jun 29, 2023

bedware commented Jul 12, 2023

bedware commented Jul 12, 2023

stevearc left a comment

stevearc Jul 14, 2023

stevearc Jul 14, 2023

		let l:path = substitute(l:path, '{file}', substitute(expand('%:p'), '\', '/', 'g'), 'g')
		let l:path = substitute(l:path, '{project_dir}', substitute(expand('%:p:h'), '\', '/', 'g'), 'g')

Added Windows support #57

Are you sure you want to change the base?

Added Windows support #57

Conversation

bedware commented Jun 26, 2023

bedware commented Jun 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bedware commented Jun 28, 2023

bedware commented Jun 28, 2023

stevearc commented Jun 29, 2023

bedware commented Jul 12, 2023

bedware commented Jul 12, 2023

stevearc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bedware commented Jun 26, 2023 •

edited

Loading